On Tue, Aug 20, 2013 at 05:48:21PM +0200, Florian Bruhin wrote: > * Christopher Meng <cickumqt _at_ gmail _dot_ com> [2013-08-20 22:46:58 +0800]: > > I have packaged this nice wm for Fedora since 2011 and have plan to > > push them to bugzilla review in the next week. (Me approved Fedora > > packager) Nice! > > However I would suggest that makefile should not install zsh file, as > > zsh is not the default shell in many distros. > > - We could just live with it. > > If you really insist in not installing it, can't you remove it from > the Fedora package with some post-packaging-hook or whatever? > (Also, it's in the debian package as well) > > How do other projects typically manage this? I'm really not in favour > of removing functionality just because there might be a file in the > filesystem which isn't needed. As Florian said, all Makefile-options suck. I also don't see a problem with the completion file lying in the filesystem. Hlwm does not depend on zsh (with or without the completion file), so just put it in the fedora package: non-zsh-users won't care and for zsh it works out of the box. Regards, Thorsten
Attachment:
pgpzMbzwwTR0D.pgp
Description: PGP signature