Heya, * Thorsten Wißmann <re06huxa _at_ cip _dot_ cs _dot_ fau _dot_ de> [2012-11-18 00:26:15 +0100]: > On Sat, Nov 17, 2012 at 11:41:06PM +0100, Florian Bruhin wrote: > > Attached is a patch so commands with on|off|toggle arguments > > (currently fullscreen/pseudotile/floating) default to "toggle" if no > > argument is given. > > > > For fullscreen this was already mentioned in the manpage, but not > > implemented. > > Hm, I'm still not very convinced of adding optional arguments, but maybe > it's more consistent (especially because it was described like that for > the floating command in the man page before). ACK. And as mentioned in IRC, I did "hc fullscreen" and wondered why it didn't work. ;) > > While I was at it, I also fixed some inconsistent formatting in the > > manpage regarding these options. > > Nice. More formating-fix-patches are welcome. Added to my todo-list to take a look if there are any other formatting-"bugs" in the manpage. > > -pseudotile *on*|*off*|*toggle*:: > > +pseudotile [*on*|*off*|*toggle*]:: > > Sets or toggles the pseudotile state of the focused client. If a client is > > pseudotiled, then in tiling mode the client is only moved but not resized - > > the client size will stay the floating size. The only reason to resize the > > - client is to ensure, that it fits into its tile. > > + client is to ensure, that it fits into its tile. If no argument is given, > > + fullscreen mode is toggled. > ^ > I changed that to pseudotile. Whoops, thanks! > If you change the user-visible behaviour of commands, then please also > add a NEWS entry. I did that for you: > > * floating, fullscreen, pseudotile: default to toggle if no argument > is given Oh, sure. Didn't think of that for this patch. > So it's now merged as: > > * 4849b1b Default to "toggle" for on|off|toggle commands Thanks! Florian -- () ascii ribbon campaign - stop html mail www.asciiribbon.org /\ www.the-compiler.org | I love long mails http://email.is-not-s.ms/ The closest to perfection a person ever comes is when he fills out a job application form. -- Stanley J. Randall
Attachment:
pgpXDb2GAq2CX.pgp
Description: PGP signature