[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] attempted close_and_remove command



Hi,

Just some things I changed in your patch before mergin it:

> Subject: [PATCH] Squashed commit of the following:
> […]

This has no real information because the squashed patch is really small.
Furthermore, the first line of the commit-description should describe
the content of the patch (and not how you created the patch...). So this
is more appropriate:

Subject: Add close_and_remove command

I also added the same line as an entry in the NEWS file.

The code looks good. Notice that the behaviour will be strange if the
window does not close immediately. (Maybe this should be added to the
doc...)

The patch is merged as:

82f56f7 Add close_and_remove command

Cheers,
Thorsten

Attachment: pgpFmF72se5Aq.pgp
Description: PGP signature