On Tue, Feb 04, 2014 at 02:08:42PM +0100, Thorsten Wißmann wrote: > Hi, > > I read about your intention of increasing the maintainability. But I see > most of these function as a library (A library won't delete a function > f() if the maintainers guess no application uses it). Well, hlwm is no library so changing the API is not a problem. I just noticed that those functions were unused at the moment and thought unused code doesn't have to be kept around. > For example, I will need.. > > - monitor_with_coordinate to implement monitor focussing with > focus_follows_mouse being enabled. > - monitor_with_frame for the same feature if hlwm receives a click event > on a frame window. > - hsobject_link_rename_object to rename a object, e.g. I could use it > for renaming tag/monitor objects in the future. But in this case, just keep them or drop only those which won't be useful in the near future. > It might be that we don't need the other functions anymore. Do you > really think we should remove them? If they are not used I see no reason to keep them. If they become useful in the future, the commit can always be reverted. Regards Simon -- + privacy is necessary + using gnupg http://gnupg.org + public key id: 0x92FEFDB7E44C32F9
Attachment:
signature.asc
Description: Digital signature