Re: [PATCH] Add version output to herbstclient

[Thorsten Wißmann <edu _at_ thorsten _minus_ wissmann _dot_ de>]

On Wed, Jan 08, 2014 at 08:47:09PM +0100, Florian Bruhin wrote:
> This adds a herbstclient version output which is independent from the
> hlwm version. This was requested by HolySmoke in the IRC some while
> ago.

Here, I'd like to do some inline comments...

+*-v*, *--version*::
+    Print the herbstclient version. To get the herbstluftwm version, use
+    *herbstclient version*.

Actually this is ambiguous. At first there aren't any own herbstclient
versions. The second thing is, herbstclient version gives the version of
the *running* herbstluftwm instance, herbstluftwm --version the version
of the specified herbstluftwm binary. Don't know how we should clarify
that.

And btw herbstclient -v did not work, therefore I added the following
hunk to your commit:

--- a/ipc-client/main.c
+++ b/ipc-client/main.c
@@ -162,7 +162,7 @@ int main(int argc, char* argv[]) {
     // parse options
     while (1) {
         int option_index = 0;
-        int c = getopt_long(argc, argv, "+nwc:iqh", long_options, &option_index);
+        int c = getopt_long(argc, argv, "+nwc:iqhv", long_options, &option_index);

For this commit, it's OK, not to mention it in the NEWS as it is not a
real new feature. So it's online now. We can »Clarify herbstclient man
page« later so it is online now as:

cb62c8f Add version output to herbstclient.

Cheers,
Thorsten

Attachment: pgpdfhhjOvyyh.pgp
Description: PGP signature