[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix triple-slash paths when installing
- To: Florian Bruhin <me _at_ the _minus_ compiler _dot_ org>
- Subject: Re: [PATCH] Fix triple-slash paths when installing
- From: Thorsten Wißmann <edu _at_ thorsten _minus_ wissmann _dot_ de>
- Date: Thu, 15 Aug 2013 12:38:52 +0200
On Tue, Aug 13, 2013 at 10:39:01AM +0200, Florian Bruhin wrote:
> When playing with the Makefile I realized hlwm installs things to
> paths like this by default (note the triple-slash):
>
> ///usr/local/bin
>
> After discussing a bit with the people from ##workingset on Freenode,
> they told me the most projects set DESTDIR empty by default, assume
> PREFIX starts with a slash, and then install the files to
> $(DESTDIR)$(PREFIX)/foo (note the lack of a slash after DESTDIR).
Should be OK, if we assume PREFIX starts with a slash.
> The attached patch does the same for hlwm, and also improves
> consistency a bit by using one (and only one) trailing slash for every
> "install" call.
>
> I'm not sure if this is a purely cosmetical issue, or if there are in
> fact platforms which don't resolve /// to /.
// seems to be implementation defined, but /// definitely means /,
according to stackexchange quoting posix[1].
So just let's try it and see if someone complains.
cd0eb06 Fix triple-slash for install paths
Regards,
Thorsten
[1] http://unix.stackexchange.com/questions/12283/unix-difference-between-path-starting-with-and