Re: [PATCH] Edge Wrapping

[Thorsten Wißmann <edu _at_ thorsten _minus_ wissmann _dot_ de>]

Hi Tylo,

On Tue, Dec 11, 2012 at 09:00:07AM -0800, Tyler Thomas Hart wrote:
> On Tue, Dec 11, 2012 at 8:24 AM, Tyler Thomas Hart wrote:
> > >2) _edge commands don't take '-i'|'-e' currently. This also means (focus
> > l || focus_edge r) only follows
> > >the setting, not the flag, if '-i'|'-e' is given explicitly. This can be
> > fixed in the current implimentation
> > >though, which I will do.
> > >Note that foo_edge with -i or -e will give different behavior, which is
> > why I added an argument. This is
> > >also why I made -i|-e|-w only temporary: -w assumed -i.

Your quoting is broken. (You wrapped some lines two messages before but
didn't prepend the '>'). Please fix it in your mail setup. I recommend
using a proper mailer or a good text editor for composing mails (e.g.
the gq-command in gqap does that for vim, which can be used as a
composer for mails in mutt).

> > Looks like I was wrong. shift_edge DOES take -i|-e. Ill submit a
> > patch to update the docs.
>
> Patch 0002 fixes this in the docs. The entry for shift_edge refers to the
> entry for focus_edge, so it needs to be applied second. (Or pushed all at
> once)

I don't know why someone just wants to focus the frame on the edge but
not the window on the edge, but the code looks simple so the easiest
thing is to fix the docs! Thanks.

> Patch 0001 adds command focus_edge.

That's good. I fixed the comment in frame_focus_edge() and in
frame_move_window_edge(). So your two patches are merged as:

e2f4c69 Fixed man entry for shift_edge
901101e Add command focus_edge

Regards,
Thorsten