Re: [PATCH] command cleanup

[Thorsten Wißmann <re06huxa _at_ cip _dot_ cs _dot_ fau _dot_ de>]

Hi Florian,

On Fri, Nov 02, 2012 at 07:45:29AM +0100, Florian Bruhin wrote:
> 0001 avoids an unneccesary call to get_current_monitor() like
> discussed in IRC already. There are probably more places where this
> could be done, but I'm not sure what the exact implications are and
> when the monitor *could* change and when not, so I only change this
> one.

> 0002 cleans up g_parameter_expected by making it less confusing (index
> 1 instead of 0 for commands with no arguments) and also sorts the
> commands like they are sorted in the manpage.

Thanks for these fixups. They now can be found in master as:

* aad7ae8 Clean up g_parameter_expected
* 6f05118 Avoid unneccesary get_current_monitor()-call

> 0003 and 0004 also sort g_completions and g_commands like in the
> manpage.

Do we need that? The order in the man page is: When I add a command I
try to place it next to similar commands (e.g. lock to unlock).

I really appreciate your effort but patch 0003 and 0004 don't change the
readability of the source code and the order still looks more or less
random. So I don't think we need these two patches.

Thorsten