[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] New setting: window_inner_border_width



Thorsten WiÃmann:

> Actually the double_window_border setting is obsolete if theres a
> window_border_inner_width setting (where window_inner_border_width = 0
> means, the double border is disabled).

Agreed.

However, the original variable naming is correct: the variable
designates the width of the inner border of the window. It should hence
be called window_inner_border_width. The same thing goes for
window_border_inner_color which I should have called
window_inner_border_color (I didn't want to break the current naming
scheme) and probably all the window_border_*_color are wrong too.

> By the way: I like the split into two smaller patches, but didn't really
> look into it.

I'd like to underline the fact that the first patch can be merged if
there's no problem with it.

Greetings,
-- 
 b.d
(| |)
 ^ ^

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/