[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Double Window Borders



Thorsten WiÃmann:

> On Sun, Jul 22, 2012 at 11:06:19PM +0200, Bastien Dejean wrote:
> > Thorsten WiÃmann:
> > 
> > > There are some formal things I don't like about the current patch, the
> > > code itself works as expected.
> > 
> > I fixed the issues you mentioned and I also fixed a bug in
> > window_focus:
> > 
> > The window_unfocus function was called two times:
> > - First on the previous window (that's fine) .
> > - Then on the window to be focus (not good!).
> > Hence the border blinking.
> 
> That produced other problems:
> 
>   - When cycling through the windows using the cycle command the focus
>     cycles but no window border is marked as focused. It is caused by
>     that, because your version only resets the border color on the
>     second call of window_focus, and frame_current_cycle_selection()
>     only calls it once:

I can't ignore the aforementioned bug: window_unfocus should not be
called on the window to be focused.

I think I'll wait until the underlying bugs are fixed because blinking
borders are unacceptable.

Greetings,
-- 
 b.d
(| |)
 ^ ^

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/