[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] New setting: smart_window_surroundings
- To: Bastien Dejean <nihilhill _at_ gmail _dot_ com>
- Subject: Re: [PATCH] New setting: smart_window_surroundings
- From: Thorsten Wißmann <edu _at_ thorsten _minus_ wissmann _dot_ de>
- Date: Wed, 18 Jul 2012 14:27:23 +0200
Hi Bastien,
there are two points to be fixed in your patch:
On Wed, Jul 18, 2012 at 12:32:33PM +0200, Bastien Dejean wrote:
> diff --git a/NEWS b/NEWS
> + * the setting smart_window_borders is now called smart_window_surroundings
> + and it embraces window gaps.
The NEWS file documents the changes between stable releases (aka
versions). So you don't need to describe the rename process from
smart_window_borders to smart_window_surroundings but you can directly
replace the description of the old setting by the new one.
The second one is:
patch:77: trailing whitespace.
if (!*g_smart_window_surroundings
patch:79: trailing whitespace.
&& frame->content.clients.layout != LAYOUT_MAX)) {
patch:129: trailing whitespace.
if (!*g_smart_window_surroundings
patch:131: trailing whitespace.
&& frame->content.clients.layout != LAYOUT_MAX)) {
If you fix both, I'll merge it.
Thorsten
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/