[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCHES] Add command 'query'



On Thu, Dec 06, 2012 at 12:29:20PM -0800, Tyler Thomas Hart wrote:
> I've realized that there are a lot of unncessesary delarations. Patch 0014
> fixes this.

If you have a fixup for a patch, that isn't merged to master yet, then
please resend the fixed patch and *not* another patch that fixes a bug,
that's not there in hlwm yet. (That also applies to all other submitted
patch sets).

Sorry for letting you wait for an answer. I was very busy (and still am
today). So I'll probably check your patches tomorrow.

The answer â to the features, I didn't look at the actual patches â more
or less will be:

  - negation: That's a good feature. I first didn't added it because I
    didn't want to create yet-another scripting language
  - shift_edge: I don't know why someone needs that but if it's useful
    to you and not much code, I don't mind.
  - cycle_shift: That sounded equivalent to move_index with a relative
    index, so I guess I only have to consider shift_cycle_monitor:
  - shift_cycle_monitor: I'd prefer something like a monitor equivalent
    to move_index. The name shift_monitor should be OK, and the syntax
    should be: shift_monitor INDEX, where INDEX is either absolute,
    relative (if it's prefixed by a sign) or also a monitor name (in
    near future).
  - query: I like the basic idea, but I don't like that we have to
    implement each variable to query explicitly (ntags, nframes,...).
    But I already planned to implement something more general in near
    future. (It heavily will be inspired by KObjects known from the
    linux kernel).

Regards,
Thorsten